-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert one-click upsell to stop using TransactionFlow #48132
Comments
Some PRs that are part of this process:
|
To do this, we should first refactor
Unfortunately because we haven't converted the payment processors to use |
|
The one-click upsell code is the only remaining place using the
TransactionFlow
object which is the way that old checkout submits its payments for processing.The biggest issue here is that any fixes or updates we make to new checkout will not apply to the one-click upsell and any fixes to the upsell (eg: #47774) will be eventually lost.
We'll need to change
PurchaseModal
to use the payment processors that are part of composite checkout. This requires two things: first we need to change the inputs getting to that component to remove the dependency onCartStore
by switching toShoppingCartProvider
and second we need to replaceTransactionFlow.submit
withexistingCardProcessor
. We'll also need the rest of the "checkout complete" behavior which currently lives inuseCreatePaymentCompleteCallback
.The text was updated successfully, but these errors were encountered: