Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Unification: update Calypso color schemes for nav-unification #47795

Closed
frontdevde opened this issue Nov 26, 2020 · 1 comment
Closed

Nav Unification: update Calypso color schemes for nav-unification #47795

frontdevde opened this issue Nov 26, 2020 · 1 comment
Assignees
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.

Comments

@frontdevde
Copy link
Contributor

Heads up; in addition to porting them to wp-admin, all of these schemes need changes in calypso, too. If you turn on one of these schemes in calypso, then turn on the nav-unification flag, you still see the old wp-admin colorscheme in calypso.

Changes Needed
The scope of the scheme's current variable settings needs to be expanded to include .is-nav-unification.
Some additional color variables that only exist in calypso nav unification need to be set. These are submenu colors which exist in wp-admin and nav unification, but not regular calypso.

See #47040 (comment)

@frontdevde frontdevde added the [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. label Nov 26, 2020
@frontdevde frontdevde self-assigned this Nov 26, 2020
@frontdevde
Copy link
Contributor Author

Solved via the following list of PRs

update Classic Blue color scheme to be compatible with Nav Unification #47709
update Classic Bright color scheme to be compatible with Nav Unification #47728
update Classic Dark color scheme to be compatible with Nav Unification #47730
update Contrast color scheme to be compatible with Nav Unification #47746
update Nightfall color scheme to be compatible with Nav Unification #47751
update Powder Snow color scheme to be compatible with Nav Unification #47752
update Sunset color scheme to be compatible with Nav Unification #47786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

No branches or pull requests

1 participant