Nav Unification: add Classic Dark color scheme (default ready); prepare Classic Blue for default theme change;

[frontdevde]

Changes proposed in this Pull Request

This PR

• introduces Classic Dark as a new color scheme option (similar to the current default color scheme it has all properties set already so we can easily swap it in as the new default when we launch nav-unification)
• prepares Classic Bright for the eventual default color scheme switch to Classic Dark by adding missing colors previously inherited from Classic Bright

Context:

We will allow customers to get familiar with the new colours ahead of the nav unification launch by introducing a new non-default Classic Dark color scheme using the nav unification colors (Decision: stakeholder decision in Ajax backlog grooming meeting on Thu Nov 5th.).

Related issue: #47266

Testing instructions

• Check out branch locally, yarn && yarn start, visit http://calypso.localhost:3000/me/account
• OR use the calypso.live link (easier!)
• Select the Classic Dark color scheme in /me/account
• Compare against flags=nav-unification colors
• Navigate around Calypso and see if everything looks as expected
• Change color scheme to Classic Blue and see if it still match what you see in production.

Fixes #47266

[matticbot]

Test live: https://calypso.live/?branch=feature/add-color-scheme-classic-dark

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~51 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
account       +186 B  (+0.0%)      +51 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~89 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
async-load-design-blocks       +186 B  (+0.0%)      +41 B  (+0.0%)
async-load-design              +186 B  (+0.0%)      +48 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[mreishus]

LGTM ✔️

Only thing I noticed is that in classic dark, the selected credit card doesn't stand out very much.

Classic Blue

Classic Dark

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5163781

Hi @frontdevde, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Classic Dark

Thank you in advance!

[a8ci18n]

Translation for this Pull Request has now been finished.