-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nav Unification: How to sync with Jetpack release process? #47045
Comments
The endpoint is already in and available to us. The work in Automattic/jetpack#17629 is currently behind a filter and conditional that only activates it on simple sites and atomic. It also requires the masterbar module to be active. |
So you are suggesting releasing now (before Nov 23) all the changes we need and handling this feature visibility / availability from an other plugin wpcomsh which can be released as we please. I assume we should be deploying this toggle in wpcom too right? |
Yup, that's right! |
@obenland Let's target Code Freeze on 2020-11-23 for having in Jetpack the most stable solution dependant on a filter Automattic/jetpack#17629 @frontdevde, @getdave is there anything else we can ship to Jetpack till this date? |
Calypso Color Schemes maybe should we we decide they will live in Jetpack. Could either be also be filtered so it only shows on Simple or Atomic, or maybe Jetpack would be interested to provide other Jetpack folks with those Color Schemes as well as a feature. Working on the color scheme generation in this draft PR Automattic/jetpack#17828. |
IIRC, we are going to enable this feature (hiding scheme selection, more color-schemes) to simple & atomic customers only - not self hosted. So, yes it needs to be filtered too (by the same exact filter). |
Filters are cheap, feel free create a context-specific filter for this |
That's true. I totally forgot that we have decoupled color-schemes from nav-unification! Thanks for chiming in @obenland ! |
The "hiding scheme selection" portion should definitely be limited to Simple & WoA customers. Initially, the "more color-schemes" portion as well. That said, this portion by itself might be interesting to Jetpack as a feature i.e. adding more color schemes to wp-admin. Providing additional wp-admin color schemes to all Jetpack users might be a nice value add, especially as it's "for free" in terms of development overhead for the Jetpack team as we're working on it (and it needs to be maintained in the future for wpcom anyway). Just thinking out loud here though, uncertain of what Jetpack wants. Maybe @jeherve has thoughts on this?
Sounds good 👍 |
Yeah, I think that makes perfect sense. I don't see any reason to not offer this to Jetpack users, as long as, like you mentioned, we do not hide the scheme selection by default, and as long as everything we do can be disabled with a filter. |
@obenland @frontdevde @getdave Do y'all have a list of things that should be in before Monday evening? Automattic/jetpack#17833 Is there anything else I am missing? @pablinos Would Automattic/jetpack#17826 qualify as part of that project? Would you want this in 9.1? Thank you all! cc @anomiex who's leading the release this time around. |
Automattic/jetpack#17833 would be helpful, yes. Automattic/jetpack#17629: I wouldn't be heartbroken about it if it didn't get in. We just fixed another bug in it and it needs follow-up work anyway. |
Automattic/jetpack#17828 won't be ready for 9.2, we're aiming for the 9.3 release. |
It seems both Let's do it! |
Since we are planning in shipping the backend code in Jetpack, we need to align with the Jetpack Release dates so that the feature lands on Atomic sites the same time as it lands on wpcom.
Scheduled Releases
Let's make sure that we have aligned with Jetpack and we have prepared everything they need for a release.
The text was updated successfully, but these errors were encountered: