Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Unification: How to sync with Jetpack release process? #47045

Closed
cpapazoglou opened this issue Nov 3, 2020 · 15 comments
Closed

Nav Unification: How to sync with Jetpack release process? #47045

cpapazoglou opened this issue Nov 3, 2020 · 15 comments
Assignees
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.

Comments

@cpapazoglou
Copy link
Contributor

Since we are planning in shipping the backend code in Jetpack, we need to align with the Jetpack Release dates so that the feature lands on Atomic sites the same time as it lands on wpcom.

The Jetpack release will happen on December 1st. As a general rule of thumb, you may expect a Jetpack release on the first Tuesday of each month. Code freeze and first Beta is one week before the release date, on the last Tuesday of the month.

Scheduled Releases

9.2 9.3
Code Freeze on 2020-11-23 Code Freeze on 2021-01-04
Beta Release on 2020-11-24 Beta Release on 2021-01-05
Release on 2020-12-01 Release on 2021-01-12

Let's make sure that we have aligned with Jetpack and we have prepared everything they need for a release.

@cpapazoglou cpapazoglou added [Type] Question [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. labels Nov 3, 2020
@cpapazoglou cpapazoglou added this to the Nav Unification v1 Rollout milestone Nov 3, 2020
@cpapazoglou
Copy link
Contributor Author

@obenland, @jeherve could please chime in case you have something to add?

@obenland
Copy link
Member

obenland commented Nov 4, 2020

The endpoint is already in and available to us. The work in Automattic/jetpack#17629 is currently behind a filter and conditional that only activates it on simple sites and atomic. It also requires the masterbar module to be active.
We can use that filter to set visibility of the feature from wpcomsh.

@cpapazoglou
Copy link
Contributor Author

cpapazoglou commented Nov 5, 2020

So you are suggesting releasing now (before Nov 23) all the changes we need and handling this feature visibility / availability from an other plugin wpcomsh which can be released as we please. I assume we should be deploying this toggle in wpcom too right?

@obenland
Copy link
Member

obenland commented Nov 5, 2020

Yup, that's right!

@cpapazoglou cpapazoglou self-assigned this Nov 16, 2020
@cpapazoglou
Copy link
Contributor Author

@obenland Let's target Code Freeze on 2020-11-23 for having in Jetpack the most stable solution dependant on a filter Automattic/jetpack#17629

@frontdevde, @getdave is there anything else we can ship to Jetpack till this date?

@frontdevde
Copy link
Contributor

@frontdevde, @getdave is there anything else we can ship to Jetpack till this date?

Calypso Color Schemes maybe should we we decide they will live in Jetpack. Could either be also be filtered so it only shows on Simple or Atomic, or maybe Jetpack would be interested to provide other Jetpack folks with those Color Schemes as well as a feature. Working on the color scheme generation in this draft PR Automattic/jetpack#17828.

@cpapazoglou
Copy link
Contributor Author

@frontdevde, @getdave is there anything else we can ship to Jetpack till this date?

Calypso Color Schemes maybe should we we decide they will live in Jetpack. Could either be also be filtered so it only shows on Simple or Atomic, or maybe Jetpack would be interested to provide other Jetpack folks with those Color Schemes as well as a feature. Working on the color scheme generation in this draft PR Automattic/jetpack#17828.

IIRC, we are going to enable this feature (hiding scheme selection, more color-schemes) to simple & atomic customers only - not self hosted. So, yes it needs to be filtered too (by the same exact filter).

@obenland
Copy link
Member

by the same exact filter

Filters are cheap, feel free create a context-specific filter for this

@cpapazoglou
Copy link
Contributor Author

by the same exact filter

Filters are cheap, feel free create a context-specific filter for this

That's true. I totally forgot that we have decoupled color-schemes from nav-unification! Thanks for chiming in @obenland !

@frontdevde
Copy link
Contributor

IIRC, we are going to enable this feature (hiding scheme selection, more color-schemes) to simple & atomic customers only - not self hosted. So, yes it needs to be filtered too (by the same exact filter).

The "hiding scheme selection" portion should definitely be limited to Simple & WoA customers.

Initially, the "more color-schemes" portion as well. That said, this portion by itself might be interesting to Jetpack as a feature i.e. adding more color schemes to wp-admin. Providing additional wp-admin color schemes to all Jetpack users might be a nice value add, especially as it's "for free" in terms of development overhead for the Jetpack team as we're working on it (and it needs to be maintained in the future for wpcom anyway).

Just thinking out loud here though, uncertain of what Jetpack wants. Maybe @jeherve has thoughts on this?

Filters are cheap, feel free create a context-specific filter for this

Sounds good 👍

@frontdevde frontdevde reopened this Nov 19, 2020
@jeherve
Copy link
Member

jeherve commented Nov 19, 2020

Providing additional wp-admin color schemes to all Jetpack users might be a nice value add, especially as it's "for free" in terms of development overhead for the Jetpack team as we're working on it (and it needs to be maintained in the future for wpcom anyway).

Yeah, I think that makes perfect sense. I don't see any reason to not offer this to Jetpack users, as long as, like you mentioned, we do not hide the scheme selection by default, and as long as everything we do can be disabled with a filter.

@jeherve
Copy link
Member

jeherve commented Nov 19, 2020

@obenland @frontdevde @getdave Do y'all have a list of things that should be in before Monday evening?

Automattic/jetpack#17833
Automattic/jetpack#17629
Automattic/jetpack#17828

Is there anything else I am missing?

@pablinos Would Automattic/jetpack#17826 qualify as part of that project? Would you want this in 9.1?

Thank you all!

cc @anomiex who's leading the release this time around.

@obenland
Copy link
Member

Automattic/jetpack#17833 would be helpful, yes.

Automattic/jetpack#17629: I wouldn't be heartbroken about it if it didn't get in. We just fixed another bug in it and it needs follow-up work anyway.
Automattic/jetpack#17828 looks like it might not be ready in time

@frontdevde
Copy link
Contributor

frontdevde commented Nov 23, 2020

Automattic/jetpack#17828 won't be ready for 9.2, we're aiming for the 9.3 release.
We discussed this in our Backlog Grooming meeting, I should've added a note here as well.

@cpapazoglou
Copy link
Contributor Author

It seems both nav-unification and color-schemes are aiming for the 9.3 release.
As a reminder Code Freeze is on 2021-01-04, since most of us will be AFK during Christmas we should have completed all necessary works till Dec 18 !

Let's do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Development

No branches or pull requests

4 participants