Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav unification - improve Reader sidebar markup #46095

Closed
frontdevde opened this issue Oct 1, 2020 · 1 comment · Fixed by #47198
Closed

Nav unification - improve Reader sidebar markup #46095

frontdevde opened this issue Oct 1, 2020 · 1 comment · Fixed by #47198
Assignees
@cpapazoglou
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task

Comments

@frontdevde
Copy link
Contributor

During our most recent exploration it became obvious that the reader sidebar has some markup issues and the use of classes varies compared to our unified sidebar, causing styling issues.

Screenshot 2020-10-01 at 14 22 21

In addition to styling and markup issues, there's an issue with too many items in flyout menus. This issue is also being tracked in #46094:

Flyout menus with a lot of items currently also get cut off. This is an issue with the reader in particular. In wp-admin the same can happen if there are too many items in a menu. It just doesn't surface as reader level submenus are uncommon.
One suggestion from design was to limit the number of items shown in the reader submenu to 5 items.
@frontdevde frontdevde added [Type] Task [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. labels Oct 1, 2020
This was referenced Oct 1, 2020
Closed
Closed
@getdave getdave changed the title Nav unification - improve reader sidebar Nav unification - improve Reader sidebar styling and markup Nov 2, 2020
@getdave getdave changed the title Nav unification - improve Reader sidebar styling and markup Nav unification - improve Reader sidebar markup Nov 2, 2020
@getdave
Copy link
Contributor

getdave commented Nov 2, 2020

Updated this Issue to limit the scope to a single "Issue".

@cpapazoglou cpapazoglou self-assigned this Nov 6, 2020
@cpapazoglou cpapazoglou mentioned this issue Nov 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpapazoglou cpapazoglou

Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix html invalid markup, propagate react extra props Automattic/wp-calypso
3 participants
@getdave @frontdevde @cpapazoglou