Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple admin menu items in "selected" state #46039

Closed
getdave opened this issue Sep 30, 2020 · 0 comments · Fixed by #46050
Closed

Multiple admin menu items in "selected" state #46039

getdave opened this issue Sep 30, 2020 · 0 comments · Fixed by #46050
Assignees
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task

Comments

@getdave
Copy link
Contributor

getdave commented Sep 30, 2020

Currently on master in Calypso it is possible to end up in a state where multiple admin menu items are in a "selected" state.

Screen Shot 2020-09-30 at 10 49 29

This is not inline with the WPAdmin experience.

One fix for this would be to only allow one item to be selected at a time. That's a good idea, however when menus are expanded, removing the selected state causes them to "collapse" which could cause the menu to "jump" around.

A better idea might be to:

  • Only allow 1 item to be "selected" at any one time.
  • Allow submenus to remain "expanded" even if they aren't selected. This would avoid the layout jumps.

Note that some of the behaviour above is not perceivable on WPAdmin because it uses full page reloads.

@getdave getdave added [Type] Task [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. labels Sep 30, 2020
@getdave getdave self-assigned this Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant