-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize Support URL for HSTS Tooltip in Domain Picker #45610
Comments
From #40080 (comment):
@lancewillett out of curiosity, would the same principle apply to links within a pop-up, such as the one in this issue? I believe that the link could be swapped for the Support Article Dialog along with being localised. |
Handing the baton to @rickybanister to help answer your question, @Aurorum (I miss you all wonderful people, I'm working on Tumblr product experience these days!) |
@Aurorum that's a good point and I think it would be an appropriate UX to avoid popping folks over to a new browser tab etc. I'm not sure, however, whether we have access to the support article dialog component within this onboarding context. I'll have to leave that up to @tjcafferkey or @simison to answer. |
@lancewillett ah, okay, best of luck with the Tumblr work! :) @rickybanister thank you - that's a good point about access to the component too. |
@rickybanister we currently don't have access to the support article dialog component within this context unfortunately. I know we usually move common Calypso components from |
Summarizing the complications that prevent the above suggestions from being implemented: The packages noramlly used in Calypso to url localization such as A quick implentation/workaround for this localization can be done by getting the locale and manually creating the localized support url. For example:
Worthwhile to note this @automattic/langauge-picker issue for future use. |
Background
When users are presented with domain suggestions for domains that require HSTS (.dev TLDs for example) they are presented with tooltip which reveals information about this including a link to a support URL for more information on the topic.
What needs to be done
The
/support/https-ssl
in the component below needs to be localized.wp-calypso/packages/domain-picker/src/domain-picker/suggestion-item.tsx
Lines 101 to 107 in 4c56241
The text was updated successfully, but these errors were encountered: