-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg: hide "preview AMP" from the toolbar #42896
Comments
Yes, we agree. We actually tried to move it to the Preview dropdown but we weren't able to due to it not being extensible. Here's the relevant PR for that preview button: ampproject/amp-wp#4397 I inquired about moving to the Preview dropdown here: ampproject/amp-wp#4368 (comment) If Gutenberg were updated to make this extensible we'd happily change the AMP plugin to integrate there. |
Aside: this preview AMP button only is present in Reader and Transitional template modes, since they entail paired AMP where there is a separate URL for AMP va the canonical non-AMP URL. In Standard mode, the AMP pages are canonical so there is no separate AMP preview button. |
Opened an issue for this: WordPress/gutenberg#25309 |
@simison I'm going to remove this from the Flow Patrol board since the work in the PR immediately above here will enable the preferred long-term fix of adding AMP to the preview dropdown. |
With AMP plugin 1.5.0, we got "Preview AMP" button now on the header toolbar on Atomic sites (which run the latest version of the plugin). We don't have that currently for simple sites, but it would pop up there too once we upgrade.
It shows up for post editor, not for the page editor.
Clicking it opens a preview to show how the post would look like on AMP.
It's a bit advanced feature for most .com customers and has too high prominence in the header toolbar. We'll need to find a better place for it.
@olaolusoga suggested moving to "Document" sidebar somehow. For now, we can just hide this and look at the placement together with other social media/SEO preview questions ahead (p58i-93P-p2).
Another place could be in the new preview dropdown:
The text was updated successfully, but these errors were encountered: