Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen Readers Cannot Interact with "View the autosave" Notice #41784

Closed
donalirl opened this issue May 5, 2020 · 3 comments
Closed

Screen Readers Cannot Interact with "View the autosave" Notice #41784

donalirl opened this issue May 5, 2020 · 3 comments
Assignees
Labels
Accessibility (a11y) [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] High Address as soon as possible after BLOCKER issues [Size] S Small sized issue [Type] Bug

Comments

@donalirl
Copy link

donalirl commented May 5, 2020

Steps to reproduce

  1. Make an edit to a page or post and reload the page without saving. The goal is to trigger the notice "There is an autosave of this post that is more recent than the version below. View the autosave"
  2. Attempt to interact with this notice using a screen reader

What I expected

I expected to be able to swipe left to right with a screen reader through the options this notice gives a user. I should be able to tap to open the autosave, or swipe over to the dismiss button then tap to dismiss the notice.

What happened instead

Either nothing happens or the page freezes.

Screenshot

https://d.pr/i/XnjhEA

Browser / OS version

Desktop
Mac Catalina with Safari 13 using Apple Voiceover

Smartphone

  • Device: iPod Touch
  • Browser: Safari Latest
  • Screen reader: Apple Voiceover

Context / Source

#p4vt7e-6n-p2

#journey #empathy #livesharing #accessibility #painpoint #user-report

@donalirl donalirl added [Feature] Post/Page Editor The editor for editing posts and pages. Accessibility (a11y) labels May 5, 2020
@davemart-in davemart-in added [Size] S Small sized issue [Type] Bug labels Jun 27, 2020
@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@kwight kwight added the [Pri] High Address as soon as possible after BLOCKER issues label Jul 20, 2021
@sixhours sixhours self-assigned this Aug 5, 2021
@sixhours
Copy link
Contributor

sixhours commented Aug 5, 2021

I tested this on my iPhone and desktop with Voiceover and can confirm the draft/autosave is loaded properly and can be accessed by tapping/tabbing depending on the device:

Screen.Recording.2021-08-05.at.1.34.00.PM.mov

That said, this appears to be a slightly different notice from the one mentioned in the original ticket. This is a local browser storage backup notice. I'm not sure how to trigger the "View the autosave" notice here.

@sixhours
Copy link
Contributor

sixhours commented Aug 5, 2021

Aha, figured out how to trigger the autosave notice; make a change and immediately Preview the change, then reload without saving.

I'm still able to navigate to the autosave link, both on desktop and my iPhone, and dismiss the notice in either case:

Screen.Recording.2021-08-05.at.1.57.47.PM.mov

I've browsed through the closed PRs in Gutenberg and the commit history to the file where that message is located to see if I could find the one. Nothing jumps out at me, although the main component was completely refactored back in December: WordPress/gutenberg@225b075#diff-d364bf913a3b8f8eb8f79e2b52c75bd4130248c5a7c94fe021dc39602b19b697 and there's been work done around focusing in the editor: WordPress/gutenberg#28191

Short of testing past iterations of Gutenberg with git bisect or something, I'm going to say this was fixed at some point in the last year. Feel free to reopen if there's something I've missed!

@sixhours sixhours closed this as completed Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility (a11y) [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] High Address as soon as possible after BLOCKER issues [Size] S Small sized issue [Type] Bug
Projects
None yet
Development

No branches or pull requests

4 participants