People Invites: make welcome notice non-global

[rickybanister]

Currently we use a global notice to display the welcome message when a user accepts an invite. Global notices shouldn't be used for wordy multi-line messages. Let's stick with an in-page notice for this with a standard dismiss button.

Before:

[rickybanister]

Our change to the global notices also affected the email verification message we show to users that have just signed up. I think it may be beneficial to work on a possible new component or variation of global notice that works well for these special case notices with a lot of text. They would benefit from friendly graphics as well. I'll think about an alternative so perhaps we don't need to rush to apply the recommended fix above.

[lancewillett]

Possible related: #5185

[designsimply]

Tested and confirmed using the following testing steps:

1. Log in as the inviter
2. Go to My Sites > People > Invite user
3. Enter the username of the invitee
4. Click the "Send Invitation" button
5. Go to the email inbox for the invitee and copy the "Accept invitation" link
6. Log out
7. Log in as the invitee
8. Go the the "Accept Invitation" link that was copied a few steps earlier
9. Click the "Join" button

Result: a really large, green global notice appears that says:

You're now an Administrator of: Just Another Test Blog with a Very Long Title

This is your site dashboard where you will be able to manage all aspects of Just Another Test Blog with a Very Long Title

Video: 48s

^{Seen at https://wordpress.com/posts/17567174 logged in as the invitee (user552) using Firefox 48.0.1 on Mac OS X 10.11.6}

[rickybanister]

The new 'first look' design would be a much better experience for users that have just accepted an invitation. It would cover the screen, welcome them, and allow them to dismiss it after learning a bit about this whole new world.

[hoverduck]

#bug-scrub

Confirmed this is still an issue as described above. @ebinnion this is in your bin, do you have a milestone we could put this under, or should we just set it aside under [Type] Low Priority for now?

[rickybanister]

If we can swap this notice to a non-global one in a very short amount of time, that seems worth it as a temporary fix, but otherwise we will be doing some overhaul to the invite process for Jetpack sites and perhaps we can make all users benefit from that work. If @ebinnion doesn't have time to swap this over we can just close this issue for now.

[ebinnion]

Adding the non-global notice isn't too difficult. But, I'd rather do it after I refactor invites to use Redux that way we can get rid of setting a localStorage value. I intend on doing some invites work in the new year.

I created a milestone and have added this issue there.

[stale]

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week.
If you would like it to remain open, can you please you comment below and see what you can do to get things moving with this issue?
Thanks! 🙏