Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg: Convert to Blocks Prompt [3] #33043

Closed
gwwar opened this issue May 14, 2019 · 1 comment · Fixed by #33326
Closed

Gutenberg: Convert to Blocks Prompt [3] #33043

gwwar opened this issue May 14, 2019 · 1 comment · Fixed by #33326
Assignees
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Type] Task

Comments

@gwwar
Copy link
Contributor

gwwar commented May 14, 2019

In this task lets add a prompt to ask folks to convert the post when opening a post made in the Classic editor in Gutenberg. (Gutenberg has this option under the classic block, but we'll want to surface this functionality).

50568850-1d5ed180-0d0d-11e9-9722-6d80d4c8eae4

screen shot 2018-08-09 at 3 47 22 pm

This was previously implemented in #29790, but should be added to our latest integration.

To outline behavior requirements:

  • Opening a post with a single Classic block displays the prompt
  • Clicking on Convert to Blocks will convert the classic blocks
  • Folks may undo this action using normal Editor undo

Implementation wise, this may be done at /block-editor only, or at both /wp-admin and /block-editor. Depending on what folks choose we may need an additional Jetpack PR, or use core dialog components.

See also prior work in p7jreA-22i-p2 and discussion in p58i-7OD-p2
See PCYsg-l4k-p2 and PCYsg-l4k-p2 for how the integration works

@gwwar gwwar added [Goal] Gutenberg Working towards full integration with Gutenberg [Type] Task labels May 14, 2019
@jeraldjuice jeraldjuice self-assigned this May 14, 2019
@gwwar gwwar changed the title Gutenberg: Convert to Blocks Prompt Gutenberg: Convert to Blocks Prompt [3] May 17, 2019
@mtias
Copy link
Member

mtias commented May 28, 2019

It would be good to assure users that this can be undone if something doesn't look right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants