Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People: Hide UI Actions for editing wp.com owner when logged in as another Admin. #3299

Closed
BrookeDot opened this issue Feb 14, 2016 · 2 comments

Comments

@BrookeDot
Copy link
Contributor

Reported by @lizkarkoski

When logged in as an Admin there is the option available to delete the site owner. When you click the 'Save changes' button you receive the error message "There was an error deleting @user_name". Since deleting is not permitted we should hide this option.

Related to #3140

@BrookeDot BrookeDot changed the title People: Hide delete button for owner when logged in as an Admin. People: Hide actions for owner when logged in as another Admin. Feb 21, 2016
@BrookeDot
Copy link
Contributor Author

To provide a bit more context. When logged in as an admin on a site (who is not the owner) you are able to visit the edit link (people/edit/) and attempt to manage the site owner's role or remove them.
screenshot_21-02-2016-14 08 08
Instead it would make more sense to show a message like this:
screenshot_21-02-2016-14 18 20

When trying to change the role of the owner
screenshot_21-02-2016-14 19 28
I did notice we are still changing the label and the drop down until page refresh giving the illusion the role has been changed.

When trying to delete owner
screenshot_21-02-2016-14 21 00

@BrookeDot BrookeDot changed the title People: Hide actions for owner when logged in as another Admin. People: Hide UI Actions for editing wp.com owner when logged in as another Admin. Feb 21, 2016
@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant