Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No failure notice when invalid credentials are entered #32154

Closed
MichaelArestad opened this issue Apr 9, 2019 · 1 comment
Closed

No failure notice when invalid credentials are entered #32154

MichaelArestad opened this issue Apr 9, 2019 · 1 comment
Assignees
@oskosk @eliorivero
Labels
[Pri] Normal Schedule for the next available opportuinity. Rewind [Type] Bug

Comments

@MichaelArestad
Copy link
Contributor

What happened

Manually entering a garbage password on a site results in a notice saying "Testing connection..." It never changes. An error shows in the console:

image

What is expected

There should be a failure notice (it already exists, but isn't showing) to let the user know something is wrong with the credentials.
@MichaelArestad MichaelArestad added [Type] Bug [Pri] Normal Schedule for the next available opportuinity. Rewind labels Apr 9, 2019
@MichaelArestad MichaelArestad mentioned this issue Apr 9, 2019
Closed
@oskosk
Copy link
Contributor

oskosk commented Apr 26, 2019

This was fixed the day after this issue was filed in #32180. Closing.

@oskosk oskosk closed this as completed Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskosk oskosk

@eliorivero eliorivero

Labels
[Pri] Normal Schedule for the next available opportuinity. Rewind [Type] Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oskosk @eliorivero @MichaelArestad