Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Word lookup issues in OS X #317

Closed
kriskarkoski opened this issue Nov 20, 2015 · 1 comment
Closed

Editor: Word lookup issues in OS X #317

kriskarkoski opened this issue Nov 20, 2015 · 1 comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug
Milestone

Comments

@kriskarkoski
Copy link
Contributor

Combining four issues with the 3-finger word lookup shrtcut in OS X into this one issue:

Word lookup in title in Chrome:

What I Did:

  • Three-finger tap on word in title to look up the word in the built-in OS X dictionary

What I Expected:

  • To see the word highlighted and the definition in a popover

What Actually Happened:

  • The word was highlighted offset and the wrong size (Chrome)
  • The word was highlighted corrected (Safari)

dictionary in title

Word lookup in post body in Chrome:

What I Did:

  • Three-finger tap on word in post body to look up the word in the built-in OS X dictionary

What I Expected:

  • To see the word highlighted and the definition in a popover

What Actually Happened:

  • The word is show highlighted offset (this only happens in Chrome, though Safari has its own separate issues that will be recorded in another issue)

dictionary in content - chrome

Word lookup in post body in Safari:

What I Did:

  • Three-finger tap on word in post body to look up the word in the built-in OS X dictionary

What I Expected:

  • To see the word highlighted and the definition in a popover

What Actually Happened:

  • Nothing
  • In order to look up word using 3-finger tap, had to select word first and then 3-finger tap (this is not normal behavior for Safari)

dictionary in content - safari

Word lookup in title with short browser:

What I Did:

  • Three-finger tap on word in title to look up the word in the built-in OS X dictionary

What I Expected:

  • To see the word highlighted and the definition in a popover

What Actually Happened:

  • Things only work if the browser window is tall enough

dictionary in content - chrome window size

@kriskarkoski kriskarkoski added [Type] Bug [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] High labels Nov 20, 2015
@kriskarkoski kriskarkoski added this to the Editor: Next milestone Nov 20, 2015
@designsimply
Copy link
Contributor

designsimply commented Dec 20, 2017

#bug-scrub #pre-gutenburg-bug-purge

I tested with Firefox 57.0.1, Safari 11.0.1, and Chrome 63.0.3239.84 on macOS 10.13.2 and there was a slight offset in the highlighted word in the title in Chrome but not very much.

screen shot 2017-12-20 at wed dec 20 3 09 16 pm

Closing because the issue is minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants