Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiled gallery block: styles for links in captions #29729

Closed
simison opened this issue Dec 22, 2018 · 4 comments
Closed

Tiled gallery block: styles for links in captions #29729

simison opened this issue Dec 22, 2018 · 4 comments
Labels
[Block] Tiled Gallery Design [Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Low Address when resources are available.

Comments

@simison
Copy link
Member

simison commented Dec 22, 2018 •
edited
Loading

When adding links to image captions, they're blue while other caption is white.

Against dark images, blue links don't really work.

screenshot 2018-12-27 at 22 53 05

screenshot 2018-12-27 at 22 53 48
@simison simison added [Pri] Low Address when resources are available. [Goal] Gutenberg Working towards full integration with Gutenberg [Block] Tiled Gallery labels Dec 22, 2018
@geekpulp
Copy link

geekpulp commented Dec 24, 2018 •
edited
Loading

I've never contributed to a project like this before but I wouldn't mind giving this one a crack? @simison could you give some more detail? maybe attach a screenshot of the issue in action?

@simison simison added the Design label Dec 28, 2018
@simison
Copy link
Member Author

simison commented Dec 28, 2018

@geekpulp yay! :-) That's great to hear. I would suggest looking at issues labelled as "good first issue".

This one is tricky as we don't have design decisions yet and we have several other things going on with Captions that we need to work on first. Thanks for the offer tho!

@geekpulp
Copy link

@simison All good. Thanks for the tip about "good first issues", I'm working on one of those right now :)

@simison simison mentioned this issue Apr 1, 2019
Open
@simison simison closed this as completed Apr 1, 2019
@simison
Copy link
Member Author

simison commented Apr 1, 2019

Closing as the current block iteration doesn't have captions and this is tracked also at Automattic/jetpack#11794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Tiled Gallery Design [Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Low Address when resources are available.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simison @geekpulp