Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FoldableCard: When used at small sizes, summary prop wraps into header prop #2832

Closed
alternatekev opened this issue Jan 27, 2016 · 1 comment
Closed

FoldableCard: When used at small sizes, summary prop wraps into header prop #2832

alternatekev opened this issue Jan 27, 2016 · 1 comment
Labels
Components [Type] Bug

Comments

@alternatekev
Copy link
Contributor

When using the FoldableCard on the new Sharing #1474 and Connected Apps #1477 updates, @enejb and @folletto noticed a problem with the layout at small sizes:

screen shot 2016-01-27 at 8 28 39 am

screen shot 2016-01-27 at 8 27 50 am

FoldableCard needs an update to auto-flow these elements better. By changing the foldable-card__main element to use flex: 1 1 instead of flex: 2 1 at smaller screen sizes, we get this result:

screen shot 2016-01-27 at 8 31 59 am
@alternatekev alternatekev mentioned this issue Jan 27, 2016
Merged
@alternatekev
Copy link
Contributor Author

Fixed with #2835

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Components [Type] Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alternatekev