Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: enable account selection dialog for Eventbrite #2631

Closed
designsimply opened this issue Jan 20, 2016 · 1 comment
Closed

Sharing: enable account selection dialog for Eventbrite #2631

designsimply opened this issue Jan 20, 2016 · 1 comment
Labels
[Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Pri] Low [Status] Stale [Type] Enhancement

Comments

@designsimply
Copy link
Contributor

Raised by @aduth

When connecting to an Eventbrite account from the Connections page, no account confirmation dialog is shown after the authorization has completed. Instead, it's assumed that the newest Keyring connection is to be used for the connection. This is potentially troubling in cases where a user may have more than one Eventbrite account they wish to use between one or more sites. It also forces a user to disconnect their existing connection before connecting to a different account.

We are limited to a single Eventbrite connection per site. The connection mechanism is different than Publicize in that we update a site setting using the /sites/%s/settings endpoint. The account selection dialog will need to be updated to account for these two caveats.

/cc @kwight

Comment from @designsimply

To test you will need:

  • Two separate Evenbrite accounts
  • A WordPress.com account with two sites

Steps to reproduce:

  1. Go to https://wordpress.com/sharing and select the 1st WordPress.com site
  2. Click Connect next to Eventbrite
  3. If you were already logged in to Eventbrite, click Allow, otherwise log in
  4. Confirm the 1st blog was connected to the 1st Eventbrite account
  5. Click Switch Site
  6. Click the 2nd WordPress.com blog
  7. Click Sharing
  8. Click Connect next to Eventbrite
  9. Click the "not you?" link
  10. Log in to the 2nd Eventbrite account
  11. Close the pop-up window
  12. Confirm the 2nd blog was connected to the 2nd Eventbrite account
  13. If the wrong account connects, try logging out and back in to Eventbrite in a separate tab and try connecting again

Result: when I try to connect a 2nd Eventbrite account to a 2nd blog, it doesn't prompt me to select which account I want to authorize like other Sharing connections such as Twitter:

Example

@designsimply designsimply added [Type] Enhancement [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Pri] Low labels Jan 20, 2016
@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Pri] Low [Status] Stale [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants