Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Apps: move fetching Google Apps users to data component #2504

Closed
designsimply opened this issue Jan 16, 2016 · 1 comment
Closed

Google Apps: move fetching Google Apps users to data component #2504

designsimply opened this issue Jan 16, 2016 · 1 comment
Assignees
@umurkontaci
Labels
G Suite [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@designsimply
Copy link
Contributor

Raised by @gziolo

Improve this implementation and get rid of code comment: https://github.com/Automattic/wp-calypso/blob/master/client/my-sites/upgrades/domain-management/email/google-apps-users-card.jsx#L34-L35.

It is a bit tricky because we need to fetch those data only in case we have domain selected. We need to double check if we should prevent sending request to the server when there are no Google Apps users assigned to the domain.
@designsimply designsimply added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it G Suite labels Jan 16, 2016
@umurkontaci umurkontaci self-assigned this Mar 6, 2016
@umurkontaci
Copy link
Contributor

This will be fixed with #3584

This was referenced Sep 23, 2020
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue May 11, 2021
Open
This was referenced Sep 2, 2021
Open
Open
This was referenced Jan 18, 2022
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 25, 2022
Open
@mdno mdno mentioned this issue May 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umurkontaci umurkontaci

Labels
G Suite [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@umurkontaci @designsimply