Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server Side Rendering: Move global app state to a (flux) ApplicationStore #190

Closed
hoverduck opened this issue Nov 19, 2015 · 1 comment
Closed
Assignees
Labels

Comments

@hoverduck
Copy link
Contributor

Outtake from discussion at 9287-gh-calypso-pre-oss

Accept section prop as well here. Normally the section is set via context.layout.section I think, which is an anti-pattern.

I think you mean context.layout.setState(), but I agree that it is something that should probably change. We probably should have an AppStore or something that holds global app state that can be updated via actions. As it is, we're basically treating the Layout instance as singleton.

I like that. It would be cool to tidy the getDefaultContext() data into an AppStore.

@ehg ehg modified the milestones: Themes: Future, Themes: Showcase M3-LoggedOut Dec 16, 2015
@ockham
Copy link
Contributor

ockham commented Mar 18, 2016

We now have a setSection Redux action and corresponding reducer, so I'm closing this. (No immediate need for anything else from getDefaultContext() to convert to a Redux subtree.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants