Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: String#startsWith, Array#fill, String#endsWith errors on localhost settings/traffic #18592

Closed
allendav opened this issue Oct 5, 2017 · 3 comments
Labels

Comments

@allendav
Copy link
Contributor

allendav commented Oct 5, 2017

Steps to reproduce

  1. Using Chrome (to see the Errors reported)
  2. Starting at URL: http://calypso.localhost:3000/settings/traffic/{DOMAIN}
  3. Observe the errors in dev console
  4. Miss the other errors you should have caught before starting your code review :)

These errors could cause the settings/traffic page to not work correctly on Internet Explorer clients.

What I expected

Clean, quiet dev console

What happened instead

Very angry dev console

Browser / OS version

Chrome 61 on OSX High Sierra

See also #2360 and #13271

@allendav allendav added [Feature] Site Settings All other general site settings. [Type] Bug labels Oct 5, 2017
@allendav allendav changed the title Settings: String#startsWith, Array#fill, String#endsWith errors on localhost settings/traffic (IE only?) Settings: String#startsWith, Array#fill, String#endsWith errors on localhost settings/traffic Nov 21, 2017
@allendav allendav self-assigned this Nov 21, 2017
@allendav
Copy link
Contributor Author

allendav commented Nov 21, 2017

Seems to be coming from the TitleFormatEditor component

@allendav
Copy link
Contributor Author

allendav commented Nov 21, 2017

Apparently this is unavoidable at this time

// The following polyfills exist for the draft-js editor, since

As a workaround, you can remove this call to lib/wrap-es6-functions to remove the console warnings

if ( process.env.NODE_ENV === 'development' ) {
require( 'lib/wrap-es6-functions' )();
}

@stale
Copy link

stale bot commented Oct 29, 2018

This issue has been marked as stale and will be closed in seven days. This happened because:

  • It has been inactive in the past 9 months.
  • It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Oct 29, 2018
@stale stale bot closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants