Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Scan: add a way to cancel editing settings #175

Closed
v18 opened this issue Nov 19, 2015 · 1 comment
Closed

Jetpack Scan: add a way to cancel editing settings #175

v18 opened this issue Nov 19, 2015 · 1 comment

Comments

@v18
Copy link
Contributor

v18 commented Nov 19, 2015

After clicking on 'Edit Settings' it's not possible to leave the editing screen without either (1) saving the current settings again or (2) deactivating.

Here's the screen when clicking on 'Edit Settings':

jetpack-scan-edit-settings-no-cancel

I suggest removing the 'Deactivate' link and replacing it with a 'Cancel' link (or something similar - maybe 'Cancel editing' for more clarity), like this:

jetpack-scan-edit-settings-cancel-editing

There's a 'Deactivate' button on the main screen so it's still possible to deactivate.

jetpack-scan-deactivate-link

@designsimply
Copy link
Contributor

Closing because I was unable to reproduce the problem using the following testing steps:

  1. Go to https://wpcalypso.wordpress.com/settings and select a Jetpack-connected site
  2. Click Security in the header bar
  3. Click Activate in the Jetpack Scan box
  4. Look for a Deactivate button or link

Result: I only see a Cancel button at top right while editing or in first-time setup

screen shot 2016-04-21 at 09 54 06
Seen at https://wpcalypso.wordpress.com/settings/security/wildly.disambiguously.com using Firefox 45.0.1 on Mac OS X 10.11.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants