Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: masterbar active state with Notification has glitchy transition #1686

Closed
folletto opened this issue Dec 16, 2015 · 8 comments
Closed

Comments

@folletto
Copy link
Contributor

@apeatling from #631:

I'm noticing an issue with the highlight state when going between items when one of them is notifications. It seems to complete the highlight state transition for the previously clicked item when going to the next item from notifications:

nav

licecap-

@lancewillett
Copy link
Contributor

I can't repeat this one.

@folletto
Copy link
Contributor Author

It's still present, even if it's slighter than before.
Reproduced on both Chrome and Safari.

cap-

I reopened, but I'm not sure if we consider this an issue anymore. :)

@folletto folletto reopened this Apr 11, 2016
@lancewillett
Copy link
Contributor

I vote to re-close. But will leave it for a 3rd opinion. :)

@designsimply designsimply added the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label May 19, 2016
@davewhitley
Copy link
Contributor

I don't understand exactly. Is this with the tabs themselves, or the content of the page? There is definitely a flash of the previous page if I click on a tab after Notifications.

@designsimply
Copy link
Contributor

I don't understand exactly. Is this with the tabs themselves, or the content of the page?

Looks like both to me, but it's hard to see in that animated gif. I had to watch the latest-posted one several times to spot the problem. Here's the gist of what I see in the gif:

  1. Start from your profile page
  2. Click the notifications icon
  3. Click the newspaper icon

Result: the profile page icon and header flash briefly before the Reader loads

@designsimply
Copy link
Contributor

I just tested and found it's different than the original report. In my test, I found that I have to tap twice to reach the section I want after tapping notifications. See 26s.

@folletto
Copy link
Contributor Author

I just tested and found it's different than the original report. In my test, I found that I have to tap twice to reach the section I want after tapping notifications. See 26s.

This is new. I just tested it too and I can reproduce.
Different bug.

I don't understand exactly. Is this with the tabs themselves, or the content of the page?

It's both, since they are triggered in the same way.

Keep focused on the Me icon in latest gif above when it switches back from Notifications to Reader. You'll notice for a brief moment that the Me tab flashes active, as well as its header.

@folletto folletto removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label May 20, 2016
@lancewillett
Copy link
Contributor

Closing for now — let's loop back in the future when we look again at the toolbar and navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants