Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Time Picking Format #13769

Closed
marekhrabe opened this issue May 8, 2017 · 4 comments
Closed

Inconsistent Time Picking Format #13769

marekhrabe opened this issue May 8, 2017 · 4 comments
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@marekhrabe
Copy link
Contributor

Steps to reproduce

(I'm not sure what settings determine those pickers. Experienced by my wpcom user, on site https://theplate.blog/)

  1. New post
  2. Try those two ways of scheduling

What I expected

They should be same (24hr for me)

What happened instead

One is AM/PM, second 24hr

Screenshot / Video

am-pm-24-what?

Context / Source

#dogfooding

@marekhrabe marekhrabe added [Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug When a feature is broken and / or not performing as intended labels May 8, 2017
@lancewillett
Copy link
Contributor

I ran into this today — with an internal a8c P2 site, set to 0 UTC time zone.

When I go to schedule a post, I see two immediate problems:

  • The time picker should be in UTC 0 and not my local time zone.
  • The time picker should use the same time format as the blog setting (so if 24 hour, don't show AM/PM in the text.

screen shot 2017-07-25 at 13 53 45

screen shot 2017-07-25 at 13 39 54

@lancewillett
Copy link
Contributor

@catehstn Also provided a bit of anecdotal evidence to suggest the AM/PM interface isn't a great affordance to tell which is selected.

Could we change the UI a bit to use some other "on/off" visual setting instead of the darker border? Maybe a shaded background or something else with an icon?

@rachelmcr
Copy link
Member

We now only have a single date picker in the editor. I tested and confirmed that it uses either AM/PM or 24HR time depending on the site's time format setting, so the original issues reported here no longer apply.

@lancewillett
Copy link
Contributor

Thanks for the follow-up, Rachel. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

3 participants