Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Use named SCSS variables for z-index values #1139

Closed
hoverduck opened this issue Dec 1, 2015 · 0 comments · Fixed by #1392
Closed

Framework: Use named SCSS variables for z-index values #1139

hoverduck opened this issue Dec 1, 2015 · 0 comments · Fixed by #1392

Comments

@hoverduck
Copy link
Contributor

We could create variables like this:

$bottom-layer: 0;
$middle-layer: 1;
$overlay-layer: 9999;

If we don't have some kind of system for this, we're going to end up with random z-indexes scattered throughout the code:

grep -orP --no-filename "z-index:[^;]*" stylesheets | sort | uniq -c

      8 z-index: 0
     17 z-index: 1
      5 z-index: 10
      6 z-index: 1000
      2 z-index: 10000
      1 z-index: 100000
      1 z-index: 11
      2 z-index: 11111
      2 z-index: 18
      1 z-index: 180
      1 z-index: 19
      8 z-index: 2
      5 z-index: 20
      1 z-index: 20000
      1 z-index: 201
      4 z-index: 3
      1 z-index: 30000
      1 z-index: 4000
      1 z-index: 40000
      1 z-index: 500
      1 z-index: 800
      2 z-index: 900
      3 z-index: 999
      1 z-index: 9998
      5 z-index: 9999
      1 z-index: 99999
      1 z-index: auto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants