Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purchases: Domain mapping does not get removed immediately after being cancelled #1137

Closed
gziolo opened this issue Dec 1, 2015 · 1 comment
Closed

Purchases: Domain mapping does not get removed immediately after being cancelled #1137

gziolo opened this issue Dec 1, 2015 · 1 comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug
Milestone
Amber: Backlog

Comments

@gziolo
Copy link
Member

gziolo commented Dec 1, 2015

A domain mapping should not remain in the list of upgrades after it is cancelled. We'll need to do some optimistic updating of the PurchasesStore to fix this.

I just saw this bug when testing #1036.

Comment from @stephanethomas:

We should follow the pattern implemented in #555.
@gziolo gziolo added [Type] Bug [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Dec 1, 2015
@gziolo gziolo added this to the Purchases: v2 milestone Dec 1, 2015
@fabianapsimoes fabianapsimoes modified the milestones: Purchases: v2, Purchases: Future Feb 25, 2016
@Tug
Copy link
Contributor

Tug commented Apr 7, 2016

Fixed by #4514

@Tug Tug closed this as completed Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug
Projects
None yet
Milestone
Amber: Backlog
Development

No branches or pull requests
3 participants
@Tug @gziolo @fabianapsimoes