Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: uploading existing theme should point to the theme details #11077

Closed
folletto opened this issue Jan 31, 2017 · 3 comments
Closed

Themes: uploading existing theme should point to the theme details #11077

folletto opened this issue Jan 31, 2017 · 3 comments
Labels
[Closed] Won't Fix No intention to address issue. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Enhancement

Comments

@folletto
Copy link
Contributor

blvdlsbjrz

If a user uploads a theme already uploaded we should either:

  1. Forward the user to the theme sheet
  2. Ask if the user wants to overwrite

Ideally I think the second would be better, or at least an option asking between these two options above. In the meantime however would be nice if we could just:

  1. Show a yellow message saying "The theme already exist [ show details ]" and the show details button leads to the theme sheet.
  2. Just redirect to the theme sheet (maybe too abrupt?)

In the future we should show a message (either dialog or in-page) asking the user if they mean to over-write the theme, or just see the details.

/cc @rickybanister

@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week.
If you would like it to remain open, can you please you comment below and see what you can do to get things moving with this issue?
Thanks! 🙏

@stale stale bot added the [Status] Stale label Jan 11, 2018
@folletto
Copy link
Contributor Author

Still an important UX improvement.

@stale stale bot removed the [Status] Stale label Jan 11, 2018
@worldomonation
Copy link
Contributor

Hi! I'm performing triage on older bugs as part of Quality Squad's efforts to cut down on backlog issue counts.

For reference, this is how the UI currently looks like:
Screen Shot 2021-02-02 at 5 02 51 PM

With that said, as there as not been any activity on this issue in 3 years, I am proposing that this issue be closed until work is tabled and scoped.

@worldomonation worldomonation added the [Closed] Won't Fix No intention to address issue. label Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Won't Fix No intention to address issue. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants