Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break vipgoci_run() into multiple functions #192

Closed
gudmdharalds opened this issue Jul 16, 2021 · 0 comments · Fixed by #207
Closed

Break vipgoci_run() into multiple functions #192

gudmdharalds opened this issue Jul 16, 2021 · 0 comments · Fixed by #207
Assignees
@gudmdharalds
Labels
[Type] Enhancement

Comments

@gudmdharalds
Copy link
Contributor

gudmdharalds commented Jul 16, 2021 •
edited
Loading

The vipgoci_run() function is getting long and difficult to understand. It needs to be broken into multiple functions, preferably by configuration parameters themes. This has already been done in the vip-go-compatibility-scanner project, see here -- a similar solution could be implemented for vip-go-ci.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gudmdharalds gudmdharalds

Labels
[Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Break vipgoci_run() into multiple functions Automattic/vip-go-ci
1 participant
@gudmdharalds