Remove block style registration #5368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
reviewed
Jan 19, 2022
jffng
reviewed
Jan 19, 2022
|
I've reverted the change to Seedlet Blocks as we should wait for that to be in Gutenberg before we remove it. I think this is ready for another review. |
pbking
force-pushed
the
remove/block-styles
branch
from
7c82d6c
to
db229bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
We shouldn't be implementing custom block styles in themes as users will lose them when they switch themes. This removes the custom block styles but doesn't remove the CSS, so existing implementations, and the patterns, will still work.
To test, insert patterns that use these styles (e.g. Quadrat > Query Diamond) and check that they still show correctly.