Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Blockbase child themes & incompatible style variations #6941

Closed
dsas opened this issue Mar 22, 2023 · 2 comments
Closed

[Bug]: Blockbase child themes & incompatible style variations #6941

dsas opened this issue Mar 22, 2023 · 2 comments

Comments

@dsas
Copy link
Contributor

dsas commented Mar 22, 2023

Quick summary

Jackson's Charcoal style variation has white background text and Jackson has a white background. This isn't easy to read.

Ruby wine Charcoal

There are several more examples of this and similar issues with other blockbase child themes - skivers has the same style variations and they just change a thin button outline.

The style variations don't belong to the individual themes but rather their parent theme - blockbase. The variations were added and named in #6167 but only started becoming visible in child theme after WP6.2 was merged to wpcom (see fbhepr%2Skers%2Sjcpbz%2Sjc%2Qvapyhqrf%2Spynff%2Qjc%2Qgurzr%2Qwfba%2Qerfbyire.cuc%3Se%3Qn8028o5p%23685-og & D104877-code for the merge and WordPress/gutenberg#46554 for the initial GB change)

Steps to reproduce

  1. Activate the Jackson theme
  2. In the site editor use the GS sidebar to set the style variation to charcoal

What you expected to happen

To be able to read the text

What actually happened

Couldn't read the text

Browser

Mozilla Firefox

Context

p1680136513400279-slack-C048CUFRGFQ passSY-5Al-p2#comment-11903

Platform (Simple, Atomic, or both?)

No response

Other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, easy to implement

Workaround details

  • Don't use that style variation
  • Do use it and change the text colour
@dsas dsas added [Type] Bug Something isn't working Needs triage labels Mar 22, 2023
@dsas dsas changed the title [Bug]: Jackon's charcoal style variation results in unreadable text [Bug]: Jackson's charcoal style variation results in unreadable text Mar 22, 2023
@dsas dsas changed the title [Bug]: Jackson's charcoal style variation results in unreadable text [Bug]: Blockbase child themes & incompatible style variations Apr 4, 2023
@mmtr mmtr self-assigned this Apr 5, 2023
@autumnfjeld
Copy link
Contributor

FYI on this @Automattic/lego . Discussed here https://a8c.slack.com/archives/C029FM1EH/p1680709030792759

@mmtr
Copy link
Member

mmtr commented Apr 18, 2023

Solved in #6996 + D107265-code + D107818-code.

We added a new optOutOfParentStyleVariations GS setting so child themes can opt out of inheriting style variations from the parent theme, and enabled it on some Blockbase child themes (Jackson, Kingsley, Skivers, Varese) that had headstart content with conflicting styles.

@mmtr mmtr closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants