Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockbase & Fam: No space between menu items in Safari 14.0.x #5353

Closed
supernovia opened this issue Jan 17, 2022 · 4 comments
Closed

Blockbase & Fam: No space between menu items in Safari 14.0.x #5353

supernovia opened this issue Jan 17, 2022 · 4 comments
Labels
[Status] Core fix needed This issues is coming from a bundled theme (Twenty Something)) core and is being addressed in trac. [Theme] Blockbase [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report

Comments

@supernovia
Copy link

supernovia commented Jan 17, 2022

Steps to replicate

  • View a site with a menu using an older browser, like Safari 14.0.1 (circa fall 2020)

Result

Menu in the upper right has no space between items due to poor flex support in older browsers

Expected

Space between menu items, even on slightly older systems

blockbase squished menu

I used comparium.app for testing. Note there's also a repeat "Start your wordpress.com site with this theme" bar in the screenshot, but I don't know whether users are seeing that. This user did have trouble with the menus though.

I recommended adding some left padding for now.

@supernovia supernovia added [Type] Bug Something isn't working [Theme] Blockbase User Report This issue was created following a WordPress customer report labels Jan 17, 2022
@MaggieCabrera
Copy link
Contributor

I believe this is a Gutenberg issue, not specific to the theme. It's the block that does the spacing.

@metabreakr
Copy link

I went looking for the issue and found it here: WordPress/gutenberg#37673

@supernovia
Copy link
Author

Ah thanks, @MaggieCabrera and @metabreakr. I'd searched our bugs first but couldn't find it.

@mrfoxtalbot mrfoxtalbot added the [Status] Core fix needed This issues is coming from a bundled theme (Twenty Something)) core and is being addressed in trac. label Oct 10, 2022
@mrfoxtalbot
Copy link

The underlying issue in core has been solved WordPress/gutenberg#37673

I can confirm that the spacing works fine with Blockbase:

Screen Shot on 2022-10-10 at 17:07:07

We might still want to provide a fallback for older versions of Safari, but we can close this specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Core fix needed This issues is coming from a bundled theme (Twenty Something)) core and is being addressed in trac. [Theme] Blockbase [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

4 participants