Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varia: Text color on "Image showcase portfolio layout" pre-defined layout doesn't match editor #4189

Closed
mikeicode opened this issue Jul 8, 2021 · 2 comments

Comments

@mikeicode
Copy link

The text color in the first section of the "Image showcase portfolio layout" pre-defined layout shows white text in the editor but it's dark on the published page.

Steps to replicate

Add the "Image showcase portfolio layout" pre-defined layout:

Screen Shot on 2021-07-08 at 08:08:14

View "Introduce yourself.." text in the editor and the live page.

Result

Editor:

Screen Shot on 2021-07-08 at 08:10:16

Live page:

Screen Shot on 2021-07-08 at 08:09:48

Expected

The text should be white. The issue appears to be this CSS:

.wp-block-cover-image h1:not(.has-text-color),
.wp-block-cover-image h2:not(.has-text-color),
.wp-block-cover-image h3:not(.has-text-color),
.wp-block-cover-image h4:not(.has-text-color),
.wp-block-cover-image h5:not(.has-text-color),
.wp-block-cover-image h6:not(.has-text-color),
.wp-block-cover-image p:not(.has-text-color),
.wp-block-cover h1:not(.has-text-color),
.wp-block-cover h2:not(.has-text-color),
.wp-block-cover h3:not(.has-text-color),
.wp-block-cover h4:not(.has-text-color),
.wp-block-cover h5:not(.has-text-color),
.wp-block-cover h6:not(.has-text-color),
.wp-block-cover p:not(.has-text-color) {
	color: inherit;
}

Temporary solution is to choose a preset color:

Screen Shot on 2021-07-08 at 08:12:53

The text on the thumbnail from the layout chooser also shows the incorrect dark color:

Screen Shot on 2021-07-08 at 08:14:29

  • User report: 4123398-zd-woothemes

Rockfield was the reported theme, I've tested multiple Varia child themes and they all have the issue.

@jamiepalatnik
Copy link

It looks like this is a larger issue with all Cover blocks on Varia themes. I can recreate this.

Screenshot of editor view:
Editor view Varia color bug

Screenshot of live view:
live view Varia color bug

@jordesign
Copy link
Contributor

Closing this issue - as this particular pattern is no longer in use in the page layput selector. Definitely worth following along with https://github.com/Automattic/wp-calypso/issues/58846 for related cover block issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants