Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedlet and Varia: Add support for Image block border radius #3140

Open
alaczek opened this issue Feb 1, 2021 · 6 comments
Open

Seedlet and Varia: Add support for Image block border radius #3140

alaczek opened this issue Feb 1, 2021 · 6 comments
Labels
[Pod] Design Selection Issues being looked at by the Design Selection Pod [Theme] Spearhead [Theme] Varia [Type] Enhancement New feature or request

Comments

@alaczek
Copy link
Contributor

alaczek commented Feb 1, 2021

Similar to #3093, it would be awesome to add support for the Image block border-radius setting. We've got a couple of Spearhead-based podcasting layouts to be launched shortly that would immediately benefit from this, but it's a very handy design tool in general and we would love to start taking advantage of it as soon as possible.

@alaczek
Copy link
Contributor Author

alaczek commented Feb 7, 2021

Actually, it would be great to have this universally available in Seedlet and Varia, and added to new themes going forward.

@kathrynwp kathrynwp added [Pod] Design Selection Issues being looked at by the Design Selection Pod [Type] Enhancement New feature or request labels May 13, 2021
@ianstewart
Copy link
Contributor

I haven't tested it yet but should we be expanding this to our two big parent themes?

  • Varia
  • Seedlet

So all their child themes inherit this?

@ianstewart
Copy link
Contributor

Actually, it would be great to have this universally available in Seedlet and Varia, and added to new themes going forward.

… and I just noticed @alaczek thought the same thing. I'll update the title. :)

@ianstewart ianstewart changed the title Spearhead: Add support for Image block border radius Seedlet and Varia: Add support for Image block border radius Jun 10, 2021
@andres-blanco andres-blanco self-assigned this Jul 2, 2021
@kwight
Copy link
Contributor

kwight commented Jul 8, 2021

@andres-blanco I'm having a hard time finding it, did you have a PR or diff for this?

@andres-blanco
Copy link
Contributor

This was my bad, I self assigned this and then I got caught up by something else.

I started testing this issue, but adding the theme.json in the theme root dir broke the visualization of the block editor.

I will unassign myself because I think this sprint there are more relevant things to take care of.

@andres-blanco andres-blanco removed their assignment Jul 12, 2021
@MaggieCabrera
Copy link
Contributor

I started testing this issue, but adding the theme.json in the theme root dir broke the visualization of the block editor.

Yes, we've been there too :D Adding theme.json enables the new layout container and changes how alignments work for the theme and that's a whole other can of worms so we ended up removing theme.json files from all our classic themes for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pod] Design Selection Issues being looked at by the Design Selection Pod [Theme] Spearhead [Theme] Varia [Type] Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants