New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhotoEditor lib refactor #7

Closed

1 task done

mzorz opened this issue Jul 31, 2019 · 1 comment

Labels

Contributor

mzorz commented Jul 31, 2019 •

edited

Loading

Currently in the PhotoEditor module we have the following background surfaces:

FilterImageView: it's the original background image per se
ImageFilterView: it's the GLSurfaceView used to render filters on top of the background image at its full size
BrushDrawingView: it's the transparente view layered on top of the background image on which the brush drawing/erasing happens
AutoFitTextureView: it's the TextureView used for rendering video (both previously recorded and live camera preview modes)

It'd be nice to make an abstraction of the background surface and make it either one of image/video/camera preview.

Also after adding the PhotoEditor library as a lib in #6, a few items were left over that are more suitable for a refactor PR:

remove unused ViewType.STICKER_STATIC 9346f8e
~~- [ ] refactor package name to original library package name so it's easier to extract later and contribute back to the original repo.~~ Low priority for now, can be done at any point later.

The text was updated successfully, but these errors were encountered:

mzorz added the [Type] Task label

This was referenced Jul 31, 2019

Introduce photoeditor lib as a module #6

Merged

Photo editor module refactor #11

Merged

Contributor Author

mzorz commented Aug 2, 2019

Closing via #11

mzorz closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment