Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: prevent updating / uploading a post with local URL / tempid #587

Closed
mzorz opened this issue Oct 26, 2020 · 2 comments
Closed

Bug: prevent updating / uploading a post with local URL / tempid #587

mzorz opened this issue Oct 26, 2020 · 2 comments
Assignees
Labels
Important [Type] Blocking Bug The app doesn't stop, but the user can't complete a journey or use a feature.

Comments

@mzorz
Copy link
Contributor

mzorz commented Oct 26, 2020

This only happened once – after I edited a slide in the story (editing text), the image/video could go missing and the block cannot be rendered anymore (example post). The story block looks fine on Android, I tried updating the post multiple times and made sure there are no local changes.

Actual post as uploaded to the server contains this:

<!-- wp:jetpack/story {"mediaFiles":[{"id":"tempid-14-9-0","url":"file:///storage/emulated/0/Android/media/org.wordpress.android.prealpha/WordPress%20Pre-Alpha/wp_story1603432128841_0.jpg","link":"file:///storage/emulated/0/Android/media/org.wordpress.android.prealpha/WordPress%20Pre-Alpha/wp_story1603432128841_0.jpg","alt":"","caption":"","mime":"","type":"image"},{"id":"tempid-15-9-1","url":"file:///storage/emulated/0/Android/media/org.wordpress.android.prealpha/WordPress%20Pre-Alpha/wp_story1603432129086_1.mp4","link":"file:///storage/emulated/0/Android/media/org.wordpress.android.prealpha/WordPress%20Pre-Alpha/wp_story1603432129086_1.mp4","alt":"","caption":"","mime":"","type":"video"},{"id":"tempid-16-9-2","url":"file:///storage/emulated/0/Android/media/org.wordpress.android.prealpha/WordPress%20Pre-Alpha/wp_story1603432128836_2.jpg","link":"file:///storage/emulated/0/Android/media/org.wordpress.android.prealpha/WordPress%20Pre-Alpha/wp_story1603432128836_2.jpg","alt":"","caption":"","mime":"","type":"image"}]} -->
<div class="wp-block-jetpack-story wp-story"></div>
<!-- /wp:jetpack/story -->

<!-- wp:jetpack/story {"mediaFiles":[{"id":54,"url":"https://foodieasianfood.files.wordpress.com/2020/10/wp-1603431545021.jpg","link":"https://foodieasianfood.files.wordpress.com/2020/10/wp-1603431545021.jpg","alt":"","caption":"","mime":"image/jpeg","type":"image"},{"id":55,"url":"https://foodieasianfood.files.wordpress.com/2020/10/wp-1603431545052.mp4","link":"https://foodieasianfood.files.wordpress.com/2020/10/wp-1603431545052.mp4","alt":"","caption":"","mime":"video/mp4","type":"video"},{"id":53,"url":"https://foodieasianfood.files.wordpress.com/2020/10/wp-1603431545243.jpg","link":"https://foodieasianfood.files.wordpress.com/2020/10/wp-1603431545243.jpg","alt":"","caption":"","mime":"image/jpeg","type":"image"}]} -->
<div class="wp-block-jetpack-story wp-story"></div>
<!-- /wp:jetpack/story -->
@mzorz mzorz added [Type] Blocking Bug The app doesn't stop, but the user can't complete a journey or use a feature. Important labels Oct 26, 2020
@mzorz
Copy link
Contributor Author

mzorz commented Nov 14, 2020

I was able to repro by doing this:

  1. on an existing Story post in the Post list, edit it
  2. tap on the story block to open the Story composer
  3. modify added views, etc so it saves new slides
  4. tap NEXT, then UPDATE when the bottom sheet appears
  5. while the editor shows the progress updates on the block in Gutenberg, tap BACK
  6. observe it ends up having local changes when it's finished uploading the slides
  7. open the post, and then tap UPDATE (if you try editing the block, the "Can't edit Story" dialog appears)
  8. the server will receive a Post containing local urls.

@aforcier
Copy link
Collaborator

aforcier commented Dec 4, 2020

@aforcier aforcier closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Important [Type] Blocking Bug The app doesn't stop, but the user can't complete a journey or use a feature.
Projects
None yet
Development

No branches or pull requests

2 participants