From 808bdb037e3dd600f4347f095f66e127c3f5aa9d Mon Sep 17 00:00:00 2001 From: Kat Hagan Date: Thu, 16 Jul 2020 14:36:47 -0700 Subject: [PATCH 1/3] move scrolling to child list --- lib/tag-list/style.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tag-list/style.scss b/lib/tag-list/style.scss index cdadea085..447c1bba2 100644 --- a/lib/tag-list/style.scss +++ b/lib/tag-list/style.scss @@ -10,7 +10,6 @@ flex-direction: column; flex: 1 1 auto; overflow: hidden; - overflow-y: scroll; .tag-list-title { display: flex; @@ -48,6 +47,7 @@ flex: 1 1 auto; list-style: none; padding-inline-start: 20px; + overflow-y: scroll; } .tag-list-input { From fee4d4563343b0800d7a9d645150190a8085c38b Mon Sep 17 00:00:00 2001 From: Kat Hagan Date: Thu, 16 Jul 2020 14:48:25 -0700 Subject: [PATCH 2/3] add some right padding to avoid overlapping with scrollbar --- lib/tag-list/style.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/tag-list/style.scss b/lib/tag-list/style.scss index 447c1bba2..735e7834a 100644 --- a/lib/tag-list/style.scss +++ b/lib/tag-list/style.scss @@ -48,6 +48,7 @@ list-style: none; padding-inline-start: 20px; overflow-y: scroll; + padding-right: 20px; } .tag-list-input { From 26f6720cbd2c4cc1341844a62766d9bc22a2c013 Mon Sep 17 00:00:00 2001 From: Kat Hagan Date: Thu, 16 Jul 2020 15:19:02 -0700 Subject: [PATCH 3/3] more small fixes --- lib/tag-list/style.scss | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/tag-list/style.scss b/lib/tag-list/style.scss index 735e7834a..07c7f29f5 100644 --- a/lib/tag-list/style.scss +++ b/lib/tag-list/style.scss @@ -18,6 +18,7 @@ align-items: center; line-height: 1.25em; margin-bottom: 0.25em; + box-shadow: 0 1px 1px lightgray; h2 { margin-bottom: 0; @@ -41,14 +42,34 @@ opacity: 1; } } + + &.tag-list-editing .tag-list-items { + padding-inline-start: 6px; + } } .tag-list-items { flex: 1 1 auto; list-style: none; padding-inline-start: 20px; + padding-inline-end: 16px; + padding-top: 0; + padding-bottom: 0; overflow-y: scroll; - padding-right: 20px; + margin: 0; + padding-top: 0; + padding-bottom: 0; + + svg { + cursor: pointer; + } + + .icon-trash { + margin-right: 5px; + &:hover { + color: red; + } + } } .tag-list-input {