From 9432b3b34e2f0dd3c7f5ad16702fbd05bb47ea09 Mon Sep 17 00:00:00 2001 From: "Jonathan (JB) Belcher" Date: Fri, 3 Jan 2020 13:18:41 -0500 Subject: [PATCH 1/2] Sets babel compact option to false is development Babel was outputting warnings about lodash and react-dom that it wasn't removing white space. This sets babel compact to false in order to stop those warnings. We also don't need babel to compact in development. https://babeljs.io/docs/en/options#compact --- babel.config.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/babel.config.js b/babel.config.js index 490540226..1e0984cf1 100644 --- a/babel.config.js +++ b/babel.config.js @@ -18,6 +18,9 @@ module.exports = function(api) { '@babel/plugin-syntax-dynamic-import', ]; const env = { + development: { + compact: false, + }, test: { plugins: ['dynamic-import-node'], }, From d44995d290112ef38d033c1d4ca08e3fd9c76f56 Mon Sep 17 00:00:00 2001 From: "Jonathan (JB) Belcher" Date: Fri, 3 Jan 2020 13:21:47 -0500 Subject: [PATCH 2/2] Added release note --- RELEASE-NOTES.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt index b0569b086..77a66f2d0 100644 --- a/RELEASE-NOTES.txt +++ b/RELEASE-NOTES.txt @@ -31,6 +31,7 @@ - Maintenance cleanups [#1796](https://github.com/Automattic/simplenote-electron/pull/1796), [#1797](https://github.com/Automattic/simplenote-electron/pull/1797), [#1808](https://github.com/Automattic/simplenote-electron/pull/1808), [#1809](https://github.com/Automattic/simplenote-electron/pull/1809), [#1810](https://github.com/Automattic/simplenote-electron/pull/1810), [#1811](https://github.com/Automattic/simplenote-electron/pull/1811) - Updated dependencies [#1802](https://github.com/Automattic/simplenote-electron/pull/1802) - Updated dependencies [#1821](https://github.com/Automattic/simplenote-electron/pull/1821) +- Fixed build warning [#1806](https://github.com/Automattic/simplenote-electron/pull/1806) ## [v1.13.0]