From 9c578a554f3abd8315807e05e1874ea8939bc8e6 Mon Sep 17 00:00:00 2001 From: "Jonathan (JB) Belcher" Date: Mon, 9 Dec 2019 14:13:03 -0500 Subject: [PATCH 1/2] Remove code that stops settings from scrolling on shorter screens At some point, some code was added that allowed the tabs to scroll. In adding this it caused the settings tab to display at full height and not be contained by the scroll box in the modal. This fixes https://href.li/?https://github.com/Automattic/simplenote-electron/issues/1268 --- lib/components/tab-panels/style.scss | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/components/tab-panels/style.scss b/lib/components/tab-panels/style.scss index 7f6300388..a641c53f0 100644 --- a/lib/components/tab-panels/style.scss +++ b/lib/components/tab-panels/style.scss @@ -27,12 +27,6 @@ height: 30.5em; overflow: auto; -webkit-overflow-scrolling: touch; - - // On small screens, the tab bar uses up too much space so it should - // move out of the way while scrolling. - @media only screen and (max-width: 720px) and (max-height: 640px) { - height: auto; - } } .tab-panels__column { @@ -40,4 +34,3 @@ margin: 0 auto; padding: 36px 10px 50px; } - From 0e45a142f27ee86b2524d079909dbc20cce73621 Mon Sep 17 00:00:00 2001 From: "Jonathan (JB) Belcher" Date: Mon, 9 Dec 2019 14:30:26 -0500 Subject: [PATCH 2/2] Add release notes --- RELEASE-NOTES.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt index 18d02d00d..ad0be1845 100644 --- a/RELEASE-NOTES.txt +++ b/RELEASE-NOTES.txt @@ -6,6 +6,7 @@ - Keep note open when transitioning to small screen in focus mode [#1763](https://github.com/Automattic/simplenote-electron/pull/1763) ### Fixes +- Makes settings scrollable on shorter smaller view ports [#1767](https://github.com/Automattic/simplenote-electron/pull/1767) ### Other Changes