Hotkeys don't work as expected if keyboard is set to non-latin languages.

[iamgabrielma]

Reported on 3818073-zen

Some hotkeys seem to not work if the keyboard is set to a non-latin language, but they do work if the key mapping is set to English. In this case the user reported the problem for Cyrillic in Windows, but I was able to replicate it as well for Thai in OSX.

I wonder if this could be related to using the latin convention rather than the keyboard key code value, when checking diffs like this one , at cmdOrCtrl && 'KeyT'

Expected

That hotkeys behave equal despite the keyboard layout/language used.

Observed

This behaves differently, when layout is set to Cyrillic some hotkeys work (Ctrl + Shift + I) , but other doesn't, like:

• Ctrl+/ Show keyboard shortcuts
• Ctrl+Shift+U Toggle tag list
• Ctrl+Shift+K Open note above current one, in Cyrilic works like Backspace
• Ctrl+Shift+J Open note below current one
• Ctrl+Shift+Y Toggle editing content/tags
• Ctrl+Shift+L Toggle note list (on narrow screens)
• Ctrl+Shift+P Toggle Markdown preview

Reproduced

I don't have a Windows machine in order to replicate this specific case, but I replicated the same behaviour for the OSX version, for example in Thai I cannot use cmd+L move focus to search field, while this works if my keyboard is set to Spanish or English.

Details as per the specific user problem:

• OS: Windows
• OS version: 10
• Simplenote app version: 2.7.1

[codebykat]

Yeah, I think we should be using KeyboardEvent.key as per https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code

I swear I've been down this rabbit-hole before. https://github.com/Automattic/simplenote-electron/pull/2334/files

[codebykat]

Oh, the linked diff is quite old, I think these were all changed in #2334 to use key instead of code, so maybe something else is going on. I don't see any more usages of the old KeyT type constants in the current code.

[codebykat]

Related: #2040