-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find in page (cmd+f) #1954
Comments
This is really a problem with workflow. Notes more than a screen long need search to jump to sections, esp. since sidebar search is only a filter to docs with presence, not actually jumping us to the location. Since this change, I have not found a way to search in a note in Firefox; app.Simplenote.com keeps grabbing the search keystroke or the "edit: search in this page" menu option on Firefox and forcing a global doc search in the sidebar. In Chrome, Edit: Find: Find... does actually open a search box, but Cmd-F still is captured. Can you folks take a look at this? Cmd F (or Ctrl F for windows) or Edit:Search in this page (for Firefox) from the menu should execute the browser native "in-page" search and should not be overridden. It is disappointing that Google Docs has also chosen to override find, but I hope Simplenote can be better (:-)) |
@itaysk and @michaelwexler we did update the search hotkeys to better conform to platform expectations. Ctrl+F now performs the search on the note list while Ctrl+G searches within the note. It was a difficult decision because we don't want to override the browser's native find, but also we didn't want to make things more confusing since the browser's search will return different results than the Simplenote search. For instance, if you search for You can also use Ctrl+Shift+G to jump backwards through a note to the previous search result as one might expect. |
Closed by #2078 |
|
Expected
pressing cmd+f should always search in the current note
Observed
when the side bar is collapsed, the find textbox is invisible. when it is not collapsed, the search is global.
Reproduced
I have opened this as a bug because of the sidebar issue, but I have mentioned the more general issue as well: cmd+f is considered as "find in page", and currently it's unified with global search. these should be distinct from a UX perspective (regardless of the described bug) because the resulting experience is counter intuitive.
The text was updated successfully, but these errors were encountered: