Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron: Cannot log out when you have unsynced notes #1940

Closed
belcherj opened this issue Feb 27, 2020 · 2 comments
Closed

Electron: Cannot log out when you have unsynced notes #1940

belcherj opened this issue Feb 27, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@belcherj
Copy link
Contributor

On OSX and Linux in the electron app when you have unsynced notes try loggin out. I clicked delete notes and nothing happens.

@belcherj belcherj added the bug Something isn't working label Feb 27, 2020
@belcherj belcherj changed the title Have unsynced notes and log out Electron: Cannot log out when you have unsynced notes Feb 27, 2020
@rachelmcr
Copy link
Member

I tried this on macOS 10.15.4 with Electron v. 1.17.0-beta1. I had unsynced notes and received this prompt:

Screenshot 2020-05-20 16 46 53

I selected "Delete Notes" and was logged out of the app.

I'll leave the issue open since I haven't tested Linux yet, but at least on OSX it seems to be working as expected.

@dmsnell
Copy link
Member

dmsnell commented May 20, 2020

Should have been resolved by #2066, specifically in 32dad4d.

This was broken during an Electron API change in v6.0.0
In version 1.7.11, which was in use at the time of #702 when we
started showing the message box, the dialog returned a number
to the provided callback for the response value.

When we updated in #1771 we failed to catch the breakage.

@dmsnell dmsnell closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants