Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the last glib calls, replace with libicu #1985

Closed
wants to merge 1 commit into from

Conversation

chearon
Copy link
Collaborator

@chearon chearon commented Feb 9, 2022

Removes some GLib call, replaces others with libicu. We might eventually not need Pango, at which point we could remove GLib. If we remove Pango, libicu would also be needed for grapheme iteration for font fallbacks. All operating systems come with libicu, so I thought this would be easy, but it was a pain. macOS doesn't expose headers, so we have to use the homebrew version. Windows uses different naming, and the blocker: it compiles but crashes on startup.

I'm stumped on Windows but I'll try more later, for now I wanted to get this opened.

@chearon
Copy link
Collaborator Author

chearon commented Feb 10, 2022

I ended up doing the important parts of this in #1987, we can figure the libicu nightmare when the time comes.

@chearon chearon closed this Feb 10, 2022
@chearon chearon deleted the remove-glib branch February 10, 2022 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant