-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(newspack-ui): integrate with sign in/sign up #2860
Conversation
AMP is not supported anymore
It was only here because of AMP, which is not supported anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving despite pushing my own changes since these are only small CSS fixes, refactoring, and removing some vestiges of AMP support.
🎉 This PR is included in version 3.0.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.1.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.2.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.6.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.9.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.1.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.2.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.4.0-epic-ras-acc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This PR implements the Newspack UI to the Sign in/Sign up modal and introduces changes to allow the modal integration with other components from this project.
The modal logic has been decoupled from the authentication form logic, allowing the modal management to be more easily extended to support callbacks and other customizations.
The new modal logic exposes an
openAuthModal( config )
to the reader activation library, which can be called by other components that can run a callback (another modal).The configuration allows for the following customizations:
register
orsignin
Asana tasks:
Sign In
Password
OTP
Create an account
Successful sign in
Successful registration
Example of the
openAuthModal( config )
for the modal checkoutThe example below is drafted in Automattic/newspack-blocks#1647
How to test the changes in this Pull Request:
`openAuthModal( config )``
Other information: