Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let the exceptions be thrown #1698

Merged
merged 3 commits into from
Nov 28, 2024

fix: clear errors when successfully fetching lists

e0c700b
Select commit
Loading
Failed to load commit list.
Merged

fix: let the exceptions be thrown #1698

fix: clear errors when successfully fetching lists
e0c700b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 14, 2024 in 0s

20.46% (+0.10%) compared to b7fd7e6

View this Pull Request on Codecov

20.46% (+0.10%) compared to b7fd7e6

Details

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 20.46%. Comparing base (b7fd7e6) to head (e0c700b).
Report is 1 commits behind head on trunk.

Files with missing lines Patch % Lines
...ass-newspack-newsletters-mailchimp-cached-data.php 12.50% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk    #1698      +/-   ##
============================================
+ Coverage     20.35%   20.46%   +0.10%     
+ Complexity     2670     2660      -10     
============================================
  Files            48       48              
  Lines         10640    10614      -26     
============================================
+ Hits           2166     2172       +6     
+ Misses         8474     8442      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.