Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons should only be wrapped in a column when they are not placed in a column already #239

Open
janus-reith opened this issue Jun 25, 2020 · 0 comments

Comments

@janus-reith
Copy link

janus-reith commented Jun 25, 2020

A button will always be wrapped in a new column:

$block_mjml_markup .= '<mj-column ' . self::array_to_attributes( $column_attrs ) . '><mj-button ' . self::array_to_attributes( $button_attrs ) . ">$text</mj-button></mj-column>";

This leads to breaking layouts when a button is not placed as top-level element but inside a column.
Check is_in_column and only wrap the button if false.

@janus-reith janus-reith changed the title Buttons should only be wrapped in a column when they are not placed in a column alewady Buttons should only be wrapped in a column when they are not placed in a column already Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant