Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting array default value to null #14717

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

vkarpov15
Copy link
Collaborator

Fix #6691

Summary

I took another look at #6691 and I can't see any reason for us continuing to disallow default: null on array paths. We already allow default: undefined and default: () => null, the latter of which is practically identical. Silently ignoring default: null for arrays feels more like a bug than anything, and changing it doesn't break any tests. 8.5 release is a good opportunity to make this change.

Examples

@vkarpov15 vkarpov15 added this to the 8.5 milestone Jul 2, 2024
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it does not break any tests, but it would likely be good to have new tests for this

@vkarpov15 vkarpov15 merged commit a9800f4 into 8.5 Jul 4, 2024
47 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-6691 branch July 4, 2024 13:32
vkarpov15 added a commit that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants