Allow defining index on base model that applies to all discriminators #14176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We would like to define an index on a base model, with a partial filter so that it only applies to discriminators. It's not a discriminator index (as described in #11424), because it's not specific to any one child.
We were surprised that these indexes were being silently ignored during syncing, and wondered if you are open to changing the behavior. Alternatively, please let me know if this key is just not necessary in the filter. I'm new to both Mongoose and MongoDB. Thanks!
Examples
I've added a test, where you can see that getRelatedIndexes no longer skips indexes on base models with the discriminator key, if it's just checking existence: