Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctype being stripped from inlined files #68

Closed
NotBobTheBuilder opened this issue Jul 11, 2014 · 6 comments
Closed

Doctype being stripped from inlined files #68

NotBobTheBuilder opened this issue Jul 11, 2014 · 6 comments

Comments

@NotBobTheBuilder
Copy link

As of now, there are 2 pull requests, one from @nikuph and one from @jgannonjr fixing this issue; the latter of which is over 6 months old.

Will either of these ever be acknowledged and merged, or should we consider this issue to be going unfixed?
@MethodGrab
Copy link

+1, please fix this!

@maxlapides
Copy link

+1, what's the status on this one?

@julie-ng
Copy link

+1, why are #46 or #62 which fix this problem not being merged?

@MethodGrab
Copy link

Looks like it got merged today in af0dde2!

@Andersos
Copy link
Contributor

Andersos commented Feb 3, 2015

We also got our doctype also stripped out:

We are using the recommended doctype from Ink framework

@jrit
Copy link
Collaborator

jrit commented May 7, 2015

Other than the prior fix in Oct, removing jsdom for 1.0 provided a fix through other means.

@jrit jrit closed this as completed May 7, 2015
@thasmo thasmo mentioned this issue Dec 24, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Andersos @jrit @julie-ng @maxlapides @NotBobTheBuilder @MethodGrab