Broken encoding since v9.0.0 #493

ligiaandreica · 2024-08-14T14:05:40Z

Hi! 👋 I've noticed a change in how juice deals with encoding after upgrading from v8.1.0 to v9.0.0.

Running the following command containing '

juice(
      `<body>
        <p>Hi, we&#x27;re testing!</p>
      </body>`,
    )

gives the following results:

<body>
        <p>Hi, we&#x27;re testing!</p>
</body>

<body>
        <p>Hi, we&amp;#x27;re testing!</p>
</body>

The text was updated successfully, but these errors were encountered:

AngeloChecked · 2024-08-14T15:16:44Z

@gafreax and I ran into the same issue you did, which is connected to this commit: cheeriojs/cheerio@50b5d5c. While the patch is allowed as a peer dependency, it introduced a bug: https://github.com/Automattic/juice/blob/master/package.json#L38.

One possible solution is to force the peer dependency to use the RC version in the package.json:

	"overrides": {
		"cheerio": "1.0.0-rc.12"
	},

bye!

cossssmin · 2024-08-15T07:30:43Z

Will have to check the encoding issue in particular (parser options are now passed under an xml key to cheerio, but indeed cheerio unexpectedly released a bunch of breaking changes from a Release Candidate.

We should probably pin Juice 10.x to use [email protected] otherwise v1.0.0 gets installed.

jrit · 2024-08-17T18:23:06Z

10.0.1 is released :)

cossssmin mentioned this issue Aug 15, 2024

fix: pin cheerio to latest rc.12 #494

Merged

jrit closed this as completed Aug 17, 2024

Provide feedback