Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tabs for geo-location RSS feeds #13801

Merged
merged 4 commits into from
Oct 25, 2019
Merged

Fixes tabs for geo-location RSS feeds #13801

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
920ab84
Fixes tabs for geo-location RSS feeds, issue #12051.
ChaosExAnima Oct 22, 2019
5292d0f
[not verified] Adds tab characters before geo xmlns.
ChaosExAnima Oct 22, 2019
495ec05
Update modules/geo-location/class.jetpack-geo-location.php
ChaosExAnima Oct 22, 2019
731198c
Remove trailing slash.
ChaosExAnima Oct 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/geo-location/class.jetpack-geo-location.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,9 @@ public function register_rss_hooks() {
* Add the georss namespace during RSS generation.
*/
public function rss_namespace() {
echo PHP_EOL . 'xmlns:georss="http://www.georss.org/georss" xmlns:geo="http://www.w3.org/2003/01/geo/wgs84_pos#"' . PHP_EOL;
echo PHP_EOL . "\t" . 'xmlns:georss="http://www.georss.org/georss\"';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the trailing backslash needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, good catch! Fixed in 731198c

echo PHP_EOL . "\t" . 'xmlns:geo="http://www.w3.org/2003/01/geo/wgs84_pos#"';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split apart for readability.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix/12051-georss-whitespacing

ChaosExAnima marked this conversation as resolved.
Show resolved Hide resolved
echo PHP_EOL . "\t";
}

/**
Expand Down