Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions: Apostrophe converts to unicode in emails when post is created in Gutenberg #8194

Closed
seejacobscott opened this issue Nov 16, 2017 · 2 comments
Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@seejacobscott
Copy link

seejacobscott commented Nov 16, 2017

After publishing a post using Gutenberg the subscription email that is sent will convert apostrophes to '

Steps to reproduce the issue:

  1. Make sure Jetpack is connected and subscriptions are active
  2. Create a post with Gutenberg that includes apostrophes/single-quotes
  3. When published, check the email.

What I expected:
Apostrophe/single quote characters to display

What happened instead
' displays in the character's place.

Reported by a user in 778397-zen

Screenshot (from user):

aposgutenberg2

The ticket also contains raw email contents, which also include the ' character.

Seems related to WordPress/gutenberg#3353 (comment)

@seejacobscott seejacobscott added the [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. label Nov 16, 2017
@jeherve jeherve added [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended labels Nov 16, 2017
@gravityrail
Copy link
Contributor

gravityrail commented Nov 18, 2017

Fixed in r165646-wpcom.

This was occurring because our regex to "autofix" unescaped &'s in URLs was not properly detecting unicode chars of the form &#xNN(NN);

@jeherve jeherve closed this as completed Nov 20, 2017
@austinginder
Copy link

Thanks so much! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants